lib/attrsets: Add more ways to map over/to attrsets #197004
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
10.rebuild-darwin: 0
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/1463 |
dali99
force-pushed
the
lib-mapattrs
branch
2 times, most recently
from
ac28ec3 to
30b1a82
Compare
These functions have been particularly useful while developing nixos modules Co-authored-by: h7x4 <[email protected]>
doronbehar
reviewed
Jul 30, 2023
| will be automatically incremented, starting from 0. | ||
|
|
||
| Example: | ||
| imapAttrs' (i: name: value: nameValuePair "${name}${toString i}" value + i) |
There was a problem hiding this comment.
Both functions have the same signature? If so, what is the difference between them?
There was a problem hiding this comment.
they apply f in different places, see the examples:
imapAttrs has a built in nameValuePair, calling f on just the value, you can't change the names from the input attrset.
imapAttrs' wants a function that provides a nameValuePair, so you can modify both the name and the value of the input attrset.
|
I think this is a good change generally, but each function should have:
|
This was referenced Nov 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These functions have been particularly useful while developing nixos modules
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes