-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mozlz4a: enable build on Darwin #196021
mozlz4a: enable build on Darwin #196021
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully decompresses my profile's search.json.mozlz4a.
Could you add yourself as a maintainer of this package for the Darwin part?
Result of nixpkgs-review pr 196021
run on aarch64-darwin 1
1 package built:
- mozlz4a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pshirshov! Since I plan on maintaining the search portion of the firefox home-manager module, you can add me as a darwin maintainer if you don't want to maintain it yourself.
(I have a x86_64-darwin mac to test on)
Co-authored-by: Naïm Favier <[email protected]>
@kira-bruneau please check new commit messages before merging. They do not fit the contributor guidelines. |
Oh, sorry, I missed that! 😓 - I'm too used to people force-pushing their changes. I should be more careful. |
I think that squash on merge should be enabled for the repo. |
@pshirshov I don't think we'd want to enable that, because in certain cases it makes sense to have multiple commits in one PR, and we don't want to lose that context. The normal workflow in nixpkgs is to cleanup your history locally where it makes sense (eg. amend commits instead of adding "fixup" commits) and then force push your changes. |
Here's the comment where this was first explained to me: #104836 (comment) |
Yeah, but it's really convenient not to have local copy when I do some small changes in a nix formula. Also it's possible to allow squashes together with other policies. |
See #196018