Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mujs: 2016-02-22 -> 2016-09-21 #19511

Merged
merged 1 commit into from
Oct 13, 2016
Merged

mujs: 2016-02-22 -> 2016-09-21 #19511

merged 1 commit into from
Oct 13, 2016

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Oct 13, 2016

Motivation for this change

https://lwn.net/Vulnerabilities/703246/
#19481

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@grahamc grahamc added 1.severity: security Issues which raise a security issue, or PRs that fix one 9.needs: port to stable A PR needs a backport to the stable release. labels Oct 13, 2016
@mention-bot
Copy link

@grahamc, thanks for your PR! By analyzing the history of the files in this pull request, we identified @pSub and @dezgeg to be potential reviewers.

@grahamc grahamc merged commit 9a668ec into NixOS:master Oct 13, 2016
@grahamc grahamc deleted the mujs branch October 13, 2016 12:40
@grahamc grahamc removed the 9.needs: port to stable A PR needs a backport to the stable release. label Oct 14, 2016
@grahamc grahamc mentioned this pull request Oct 14, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grahamc @mention-bot