Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvmPackages_{13,14}.lldb: fix build on x86 macOS #195013

Merged
merged 1 commit into from
Oct 10, 2022
Merged

llvmPackages_{13,14}.lldb: fix build on x86 macOS #195013

merged 1 commit into from
Oct 10, 2022

Conversation

rrbutani
Copy link
Contributor

@rrbutani rrbutani commented Oct 8, 2022 •
edited
Loading

Description of changes

This is a backport of the fixes applied to llvmPackages_15.lldb; see: #194634 (comment).

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Oct 8, 2022
@rrbutani rrbutani mentioned this pull request Oct 8, 2022
Merged
92 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Oct 8, 2022
@risicle
Copy link
Contributor

risicle commented Oct 8, 2022

Both build for me, macos 10.15.

@lovesegfault
Copy link
Member

The commit message has a typo, otherwise LGTM

@rrbutani rrbutani force-pushed the fix/lldb-x86-darwin-llvm-13-and-14 branch from b42e10c to 4c13bfd Compare October 9, 2022 02:33
@rrbutani
Copy link
Contributor Author

rrbutani commented Oct 9, 2022

my bad; fixed

@rrbutani rrbutani force-pushed the fix/lldb-x86-darwin-llvm-13-and-14 branch from 4c13bfd to d20c869 Compare October 9, 2022 02:40
@rrbutani rrbutani changed the title llvmPackges_{13,14}.lldb: fix build on x86 macOS llvmPackages_{13,14}.lldb: fix build on x86 macOS Oct 10, 2022
@lovesegfault lovesegfault merged commit 9512032 into NixOS:master Oct 10, 2022
@rrbutani rrbutani deleted the fix/lldb-x86-darwin-llvm-13-and-14 branch October 10, 2022 15:55
@rrbutani rrbutani added the 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@dtzWill dtzWill Awaiting requested review from dtzWill

@primeos primeos Awaiting requested review from primeos

@lovek323 lovek323 Awaiting requested review from lovek323

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rrbutani @risicle @lovesegfault