libxml2: enable strictDeps and enable pythonSupport when cross

[Artturin]

Description of changes

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.11 Release Notes (or backporting 22.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[jtojnar]

Will this still work with v2.10.2? The Python detection is a bit in flux.

[Artturin]

Will this still work with v2.10.2? The Python detection is a bit in flux.

no python changes in configure.ac so it should still work

diff --git a/configure.ac b/configure.ac
index 3b273654..9dedb3af 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3,7 +3,7 @@ AC_PREREQ([2.63])
 
 m4_define([MAJOR_VERSION], 2)
 m4_define([MINOR_VERSION], 10)
-m4_define([MICRO_VERSION], 0)
+m4_define([MICRO_VERSION], 2)
 
 AC_INIT([libxml2],[MAJOR_VERSION.MINOR_VERSION.MICRO_VERSION])
 AC_CONFIG_SRCDIR([entities.c])
@@ -39,7 +39,7 @@ AC_SUBST(LIBXML_VERSION_EXTRA)
 
 VERSION=${LIBXML_VERSION}
 
-AM_INIT_AUTOMAKE([1.15 foreign no-dist-gzip dist-xz])
+AM_INIT_AUTOMAKE([1.16.3 foreign no-dist-gzip dist-xz])
 AM_MAINTAINER_MODE([enable])
 AM_SILENT_RULES([yes])

[jtojnar]

Maybe I misremembered and it was actually libxslt that had the Python issues.

[Artturin]

Maybe I misremembered and it was actually libxslt that had the Python issues.

Nope
1c93ab3

[jtojnar]

🤷‍♀ I guess it is fine then. Compared py and out outputs of libxml2 and libxslt on non-cross before and after with diffoscope and looks like it is a no-op.

…

On Fri, Oct 7 2022 at 15:04:07 -07:00:00, Artturi ***@***.***> wrote: > Maybe I misremembered and it was actually libxslt that had the > Python issues. > Nope 1c93ab3 — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because your review was requested.Message ID: ***@***.***>