Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wordbook: init at unstable-2022-11-02 #194581

Merged
merged 2 commits into from
Dec 24, 2022
Merged

wordbook: init at unstable-2022-11-02 #194581

merged 2 commits into from
Dec 24, 2022

Conversation

zendo
Copy link
Contributor

@zendo zendo commented Oct 5, 2022 •
edited
Loading

Description of changes

https://github.com/fushinari/Wordbook

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@zendo zendo requested review from FRidh and jonringer as code owners October 5, 2022 11:30
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Oct 5, 2022
@chuangzhu
Copy link
Contributor 

[nix-shell:~/.cache/nixpkgs-review/pr-194581]$ ./results/wordbook/bin/wordbook 
Traceback (most recent call last):
  File "/nix/store/29rqd0jhnzfinxm21gqp5bwnlk76272i-wordbook-unstable-2022-08-30/bin/.wordbook-wrapped", line 44, in <module>
    from wordbook.main import Application
  File "/nix/store/29rqd0jhnzfinxm21gqp5bwnlk76272i-wordbook-unstable-2022-08-30/share/wordbook/wordbook/main.py", line 9, in <module>
    gi.require_version("Gdk", "4.0")
  File "/nix/store/gwq3inwc86axcxb82jpwkzci3hjpw1xd-python3.10-pygobject-3.42.2/lib/python3.10/site-packages/gi/__init__.py", line 126, in require_version
    raise ValueError('Namespace %s not available' % namespace)
ValueError: Namespace Gdk not available

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/664

@zendo zendo changed the title wordbook: init at unstable-2022-08-30 wordbook: init at unstable-2022-11-02 Nov 3, 2022
@SuperSandro2000 SuperSandro2000 merged commit 4efb5ce into NixOS:master Dec 24, 2022
@zendo zendo deleted the wordbook branch December 24, 2022 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@jtojnar jtojnar jtojnar left review comments

@chuangzhu chuangzhu chuangzhu approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zendo @chuangzhu @nixos-discourse @jtojnar @SuperSandro2000