Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for pname+version to fetchzip/fetchurl #194425

Merged
merged 8 commits into from
Oct 7, 2022
Merged

Add support for pname+version to fetchzip/fetchurl #194425

merged 8 commits into from
Oct 7, 2022

Conversation

SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 4, 2022 •
edited
Loading

Description of changes

After this commit the font was in a double fixed output derivation wrapped which is unnecessary.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 4, 2022
@SuperSandro2000 SuperSandro2000 marked this pull request as draft October 4, 2022 14:22
@SuperSandro2000 SuperSandro2000 changed the title Revert "ubuntu-font-family: use mkDerivation" Add support for pname+version to fetchzip/fetchurl Oct 4, 2022
@SuperSandro2000 SuperSandro2000 marked this pull request as ready for review October 4, 2022 16:56
@SuperSandro2000
Copy link
Member Author

FYI @erdnaxe

@SuperSandro2000 SuperSandro2000 force-pushed the remove-double-fixed-output branch from 3a0c00f to d2ff852 Compare October 4, 2022 16:57
@mweinelt mweinelt marked this pull request as draft October 4, 2022 17:00
@ofborg ofborg bot requested a review from marsam October 4, 2022 17:07
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 4, 2022
@SuperSandro2000 SuperSandro2000 marked this pull request as ready for review October 4, 2022 18:21
@SuperSandro2000 SuperSandro2000 force-pushed the remove-double-fixed-output branch from d2ff852 to fdd0db3 Compare October 4, 2022 18:23
@SuperSandro2000 SuperSandro2000 mentioned this pull request Oct 5, 2022
Open
7 tasks
@bobby285271 bobby285271 added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 5, 2022
@bobby285271 bobby285271 added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Oct 6, 2022
@AndersonTorres AndersonTorres merged commit 10c7f50 into NixOS:master Oct 7, 2022
@SuperSandro2000 SuperSandro2000 deleted the remove-double-fixed-output branch October 7, 2022 10:06
@SuperSandro2000 SuperSandro2000 mentioned this pull request Jul 16, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erdnaxe erdnaxe erdnaxe approved these changes

@7c6f434c 7c6f434c 7c6f434c approved these changes

@jtojnar jtojnar Awaiting requested review from jtojnar

@Artturin Artturin Awaiting requested review from Artturin

@bhipple bhipple Awaiting requested review from bhipple

@marsam marsam Awaiting requested review from marsam

Assignees
No one assigned
Labels
6.topic: fetch 9.needs: community feedback 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SuperSandro2000 @7c6f434c @erdnaxe @AndersonTorres @bobby285271