fetchNextcloudApp: rewrite with fetchzip & applyPatches #193075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are the following issues with the current implementation: * `fetchurl` with a tarball from GitHub appears to break occasionally because the tarballs are not necessarily reproducible. Because of that, `fetchFromGitHub` unpacks the tarball already because the contents are actually reproducible in contrast to the tarball. To have the same behavior here, we use `fetchzip` now (and `applyPatches` on top to apply additional patches if needed). * Fixes the way how patches are applied. Previously, when having patches for a git checkout of the app, these wouldn't apply because the `appname-version` prefix is missing. * Because all old hashes are broken with this, I added an evaluation check that breaks evaluation when using the old API (i.e. with `name`/`version` which are not needed anymore).
ofborg
bot
added
10.rebuild-darwin: 0
|
I think this will break nc4nix. Which isn't really a reason not to merge this, just a note that there is external tooling out there which this PR might break. |
github-actions
bot
added
6.topic: nixos
|
I'm pretty sure that it will. Added an entry to the release-notes. Anything else tbd to get this merged? %) |
ofborg
bot
added
10.rebuild-linux: 1-10
and removed
10.rebuild-linux: 0
ajs124
reviewed
Oct 2, 2022
beardhatcode
approved these changes
Oct 11, 2022
bobby285271
added
the
12.approvals: 1
ajs124
reviewed
Oct 16, 2022
| { name | ||
| , url | ||
| , version | ||
| { stdenv, fetchzip, applyPatches, ... }: |
There was a problem hiding this comment.
stdenv does not seem to be used anymore
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
There are the following issues with the current implementation:
fetchurlwith a tarball from GitHub appears to break occasionally because the tarballs are not necessarily reproducible. Because of that,fetchFromGitHubunpacks the tarball already because the contents are actually reproducible in contrast to the tarball. To have the same behavior here, we usefetchzipnow (andapplyPatcheson top to apply additional patches if needed).Fixes the way how patches are applied. Previously, when having patches for a git checkout of the app, these wouldn't apply because the
appname-versionprefix is missing.Because all old hashes are broken with this, I added an evaluation check that breaks evaluation when using the old API (i.e. with
name/versionwhich are not needed anymore).Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes