Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python310Packages.miniupnpc: fix darwin build #191739

Merged
merged 1 commit into from
Sep 19, 2022
Merged

python310Packages.miniupnpc: fix darwin build #191739

merged 1 commit into from
Sep 19, 2022

Conversation

viraptor
Copy link
Contributor

Description of changes

Fix darwin build by adding cctools (for libtool) and which (to find the right libtool).

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Sep 18, 2022
@viraptor viraptor force-pushed the miniupnpc-fix-darwin branch from b27d0ea to 667d9cf Compare September 18, 2022 05:19
@viraptor viraptor force-pushed the miniupnpc-fix-darwin branch from 667d9cf to 9aa2bf4 Compare September 18, 2022 05:40
@viraptor
Copy link
Contributor Author

@ofborg eval

1 similar comment
@risicle
Copy link
Contributor

risicle commented Sep 19, 2022

@ofborg eval

@ofborg ofborg bot requested a review from peterhoeg September 19, 2022 15:57
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Sep 19, 2022
risicle
risicle approved these changes Sep 19, 2022
View reviewed changes
Copy link
Contributor

@risicle risicle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM, macos 10.15

@risicle risicle merged commit 0851743 into NixOS:master Sep 19, 2022
@viraptor viraptor deleted the miniupnpc-fix-darwin branch September 19, 2022 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@risicle risicle risicle approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@viraptor @risicle