tandoor-recipes: init at 1.4.1 #191532
Merged
tandoor-recipes: init at 1.4.1 #191532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ambroisie
commented
Sep 16, 2022
ambroisie
commented
Sep 16, 2022
| django-js-reverse = super.django-js-reverse.overridePythonAttrs (_: { | ||
| doCheck = false; | ||
| }); |
There was a problem hiding this comment.
See ierror/django-js-reverse#114 for when this isn't needed anymore.
ambroisie
commented
Sep 16, 2022
ambroisie
force-pushed
the
add-tandoor-recipes
branch
4 times, most recently
from
4d6bb88
to
f3ce4f3
Compare
ambroisie
commented
Sep 16, 2022
ambroisie
force-pushed
the
add-tandoor-recipes
branch
2 times, most recently
from
e90189a
to
788d704
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/1196 |
ambroisie
force-pushed
the
add-tandoor-recipes
branch
4 times, most recently
from
963107b
to
08eb42f
Compare
ambroisie
force-pushed
the
add-tandoor-recipes
branch
from
08eb42f
to
38997ab
Compare
|
@SuperSandro2000 addressed all your comments. |
ambroisie
force-pushed
the
add-tandoor-recipes
branch
2 times, most recently
from
c0df50e
to
a95227f
Compare
ambroisie
force-pushed
the
add-tandoor-recipes
branch
3 times, most recently
from
950560f
to
25d511d
Compare
SuperSandro2000
approved these changes
Oct 1, 2022
ambroisie
force-pushed
the
add-tandoor-recipes
branch
from
25d511d
to
83f5c2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Closes #145244.
A whole lot of python packages that were added to get this working.
django-autocomplete-lighthas been markeddoCheck = falseto avoid having to package half a dozen more just for its tests.The frontend does not make use of
mkYarnPackage, because of the following issue.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes