Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mako: Connect dbus service to systemd service #191448

Closed
wants to merge 1 commit into from

Conversation

Rosuavio
Copy link

Patch provided dbus service file to point to systemd service file.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Patch provided dbus service file to point to systemd service file.
@Rosuavio Rosuavio mentioned this pull request Sep 16, 2022
7 tasks
@ofborg ofborg bot requested review from dywedir and Synthetica9 September 16, 2022 05:00
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Sep 16, 2022
@Rosuavio
Copy link
Author

Rosuavio commented Sep 16, 2022

Maybe, patching the dbus service does not make much sense if we don't also build the systemd service file, I am going to see why that does not end up in the derivation. They are meant to be used together. One way or the other I think I am trying to make this build/output like dunst.

@Rosuavio
Copy link
Author

This might be relevant to #57602

@Rosuavio Rosuavio closed this Feb 28, 2024
@Rosuavio
Copy link
Author

Closing, mako does not provide a systemd service file and does not officially support systemd activation. Does not seem worth doing ourselves either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant