Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

octoprint: fix build error on staging-next #190940

Merged
merged 1 commit into from
Sep 13, 2022
Merged

Conversation

gador
Copy link
Member

@gador gador commented Sep 12, 2022

Description of changes

Octoprint fails to build on current staging-next #188284, due to its flask update.
This fixes it by loosing the requirement.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

due to flask update

Signed-off-by: Florian Brandes <[email protected]>
@onny
Copy link
Contributor

onny commented Sep 13, 2022

Do you think it still works? Is there already an upstream patch or issue?

@gador
Copy link
Member Author

gador commented Sep 13, 2022

it starts and I can print the version string. I we do not apply the patch it doesn't even compile.
I'll have to pull the latest master and run it on my system to be absolutely sure. But all the tests pass, so I would be positively inclined that it works

@onny
Copy link
Contributor

onny commented Sep 13, 2022

Result of nixpkgs-review pr 190940 run on x86_64-linux 1

1 package built:
  • octoprint

@onny onny merged commit 71b3cef into NixOS:master Sep 13, 2022
@onny
Copy link
Contributor

onny commented Sep 13, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants