Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

konf: init at 0.2.0 #190760

Merged
merged 6 commits into from
Sep 13, 2022
Merged

konf: init at 0.2.0 #190760

merged 6 commits into from
Sep 13, 2022

Conversation

arikgrahl
Copy link
Contributor

Description of changes

konf is a lightweight kubeconfig manager. With konf you can use different kubeconfigs at the same time. And because it does not need subshells, konf is blazing fast!

-- https://github.com/SimonTheLeg/konf-go

See #190758

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

pkgs/development/tools/konf/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/konf/default.nix Show resolved Hide resolved
pkgs/development/tools/konf/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/konf/default.nix Outdated Show resolved Hide resolved
@azahi
Copy link
Member

azahi commented Sep 11, 2022

Also, I would advise you not to change the upstream name where possible. We probably should go with konf-go instead of konf.

@arikgrahl
Copy link
Contributor Author

Also, I would advise you not to change the upstream name where possible. We probably should go with konf-go instead of konf.

Picking konf instead of konf-go was intentional.
Konf consists of a Go binary, which is referred to as konf-go, and a corresponding shell wrapper, which is essentially the shell function konf.
The Go binary is not intended to be invoked directly, only through the particular shell function.
I guess the name konf-go was therefore only introduced to differentiate the shell function from the binary.

However, in this Nix package konf should be eventually bundled completely, covering both the Go binary and the shell function.
I would consider the integration of the latter as a follow-up issue.

Therefore, I am convinced that konf suits as the name the best.
If there are any doubts or background information lacking, I am happy to reach out to the author of the upstream project.

@arikgrahl arikgrahl requested a review from azahi September 12, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants