gobject-introspection: propagate self/targetself to avoid having to add gobject-introspection to buildInputs #189215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the flags defined in it are required if the hostPlatform can't be executed
Artturin
added
the
6.topic: cross-compilation
Artturin
changed the title
…dd gobject-introspection to buildInputs i should probably move to use the wrapper when host != build and do the canExecute things inside the wrapper.nix then i could use gobject-introspection-unwrapped in it even when host == build void also adds gobject-introspection to makeDepends when its gir build helper is used
ofborg
bot
requested review from
amaxine,
bobby285271,
dasj19,
hedning,
lovek323 and
jtojnar
ofborg
bot
added
11.by: package-maintainer
jtojnar
reviewed
Sep 8, 2022
| @@ -18,6 +18,7 @@ in | |||
|
|
|||
| (gobject-introspection-unwrapped.override args).overrideAttrs (previousAttrs: { | |||
| pname = "gobject-introspection-wrapped"; | |||
| depsTargetTargetPropagated = [ gobject-introspection-unwrapped ]; | |||
There was a problem hiding this comment.
I am still not convinced this is correct solution for the Meson issue. gobject-introspection in buildInputs only makes sense for apps (since they will need cairo’s or GLib’s typelibs). Libraries (for which the Meson’s GIR generation is relevant) should not need those.
There was a problem hiding this comment.
It would be nice to remove it but (meson,configure script,probably cmake too) build systems look for it with pkg-config and use the binary variables in the pc file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see commit msgs
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes