Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spice: Upgrade all the spice packages #18921

Merged
merged 5 commits into from
Sep 27, 2016
Merged

Spice: Upgrade all the spice packages #18921

merged 5 commits into from
Sep 27, 2016

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Sep 24, 2016

Motivation for this change

https://lwn.net/Vulnerabilities/690141/ spice has a vulnerability in everything below 0.12.7. I'm not sure if you can backport that change without the rest. Maybe a maintainer will know :)

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Somewhat related to #18856

@grahamc grahamc added 1.severity: security Issues which raise a security issue, or PRs that fix one 9.needs: port to stable A PR needs a backport to the stable release. labels Sep 24, 2016
@mention-bot
Copy link

@grahamc, thanks for your PR! By analyzing the annotation information on this pull request, we identified @wkennington, @offlinehacker and @aske to be potential reviewers

@joachifm
Copy link
Contributor

Travis says

error: anonymous function at /home/travis/build/NixOS/nixpkgs/pkgs/development/libraries/spice-gtk/default.nix:1:1 called with unexpected argument ‘enableGTK3’, at /home/travis/build/NixOS/nixpkgs/lib/customisation.nix:56:12

@grahamc grahamc force-pushed the spice branch 2 times, most recently from cbdddc0 to d5a8d7b Compare September 25, 2016 18:51
@grahamc
Copy link
Member Author

grahamc commented Sep 26, 2016

@joachifm I think this branch is good now, it builds okay and I addressed those issues with GTK. Sorry about that -- thanks for the heads up.

@grahamc
Copy link
Member Author

grahamc commented Sep 27, 2016

I built everything locally, merging and backporting.

@grahamc grahamc merged commit c992ac8 into NixOS:master Sep 27, 2016
@grahamc grahamc deleted the spice branch September 27, 2016 12:18
@grahamc grahamc removed the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants