xsel: 1.2.0 -> git-2016-09-02 #18774
Conversation
| stdenv.mkDerivation rec { | ||
| name = "xsel-${version}"; | ||
|
|
||
| version = "git-2016-09-02"; |
There was a problem hiding this comment.
git now is a part of the name. Change version to 2016-09-02-git instead.
There was a problem hiding this comment.
Ah, good point; I was just following the precedent I've seen elsewhere:
~/src/nixpkgs (nixos) λ ag 'git-\d\d\d\d-\d\d-\d\d' | wc -l
59
~/src/nixpkgs (nixos) λ ag '\d\d\d\d-\d\d-\d\d-git' | wc -l
2
There was a problem hiding this comment.
Just consulted doc/coding-conventions.xml, looks like what I want is "xsel-unstable-2016-09-02" as the full name, which probably means I should have name be "xsel-unstable" and version be "2016-09-02", since that's how nix would parse the full name.
If a package is not a release but a commit from a repository, then the version part of the name must be the date of that (fetched) commit. The date must be in
"YYYY-MM-DD"format.
Also append "unstable" to the name - e.g.,"pkgname-unstable-2014-09-23".
| buildInputs = [ xlibsWrapper autoreconfHook ]; | ||
|
|
||
| postUnpack = '' | ||
| mv $sourceRoot/README{.md,} |
There was a problem hiding this comment.
@rasendubi Otherwise autoconf will complain about there being no README file, and then it'll fail. I suppose I could also just touch README, or maybe there's a flag to tell autoconf to shut up...
|
|
||
| postUnpack = '' | ||
| mv $sourceRoot/README{.md,} | ||
| ''; | ||
|
|
||
| meta = { |
There was a problem hiding this comment.
Would you like to expand meta?
| }; | ||
|
|
||
| buildInputs = [xlibsWrapper]; | ||
| buildInputs = [ xlibsWrapper autoreconfHook ]; |
There was a problem hiding this comment.
If you also got rid of xlibsWrapper, it would be nice. I had only left it defined because so many packages were using it.
LnL7
added
the
8.has: package (update)
The last xsel release was in 2008. Since then, a number of bugs have been fixed. For example, pasting a large chunk of text (>4000 chars) into chrome would cause the current tab to hang indefinitely. A couple examples in the wild: kfish/xsel#14 kfish/xsel#13 kfish/xsel#16 https://bugs.chromium.org/p/chromium/issues/detail?id=515401 electron/electron#3116 neovim/neovim#4719
cstrahan
force-pushed
the
xsel-update
branch
from
7c8f53f to
4a4fd27
Compare
| url = http://www.vergenet.net/~conrad/software/xsel/download/xsel-1.2.0.tar.gz; | ||
| sha256 = "070lbcpw77j143jrbkh0y1v10ppn1jwmjf92800w7x42vh4cw9xr"; | ||
| stdenv.mkDerivation rec { | ||
| name = "xsel-unstable-${version}"; |
There was a problem hiding this comment.
version is not used anywhere, so could be inlined.
| platforms = stdenv.lib.platforms.unix; | ||
| meta = with lib; { | ||
| description = "Command-line program for getting and setting the contents of the X selection"; | ||
| homepage = "http://www.kfish.org/software/xsel"; |
There was a problem hiding this comment.
Could be url instead of string.
Motivation for this change
The last xsel release was in 2008. Since then, a number of bugs have
been fixed. For example, pasting a moderately sized chunk of text (>4000 chars)
into chrome would cause the current tab to hang indefinitely.
A couple examples in the wild:
"+yonly can copy 77 lines. neovim/neovim#4719Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)