-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python310Packages.sphinx-book-theme: Mark as broken #187401
Conversation
postPatch = '' | ||
''; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this?
# Missing sphinx 5.X support | ||
# https://github.com/executablebooks/sphinx-book-theme/issues/592 | ||
broken = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this wouldn't be a wheel I would suggest to patch the source instead.
Can we temporarily restore |
Having multiple versions is problematic in python packages and we should avoid this as much as possible. |
I can confirm that this package is not compatible with Sphinx 5. |
The sphinx-book-theme has been updated, we will need to update this soon: executablebooks/sphinx-book-theme#592 |
Description of changes
Package missing Sphinx 5 support and is therefore incompatible executablebooks/sphinx-book-theme#592
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes