Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python310Packages.sphinx-book-theme: Mark as broken #187401

Merged
merged 2 commits into from
Oct 3, 2022

Conversation

onny
Copy link
Contributor

@onny onny commented Aug 19, 2022

Description of changes

Package missing Sphinx 5 support and is therefore incompatible executablebooks/sphinx-book-theme#592

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Comment on lines 26 to 28
postPatch = ''
'';

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this?

Comment on lines +42 to +44
# Missing sphinx 5.X support
# https://github.com/executablebooks/sphinx-book-theme/issues/592
broken = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this wouldn't be a wheel I would suggest to patch the source instead.

@urkud
Copy link
Contributor

urkud commented Aug 26, 2022

Can we temporarily restore sphinx-4.x?

@SuperSandro2000
Copy link
Member

Can we temporarily restore sphinx-4.x?

Having multiple versions is problematic in python packages and we should avoid this as much as possible.

@drupol
Copy link
Contributor

drupol commented Sep 24, 2022

I can confirm that this package is not compatible with Sphinx 5.

@drupol
Copy link
Contributor

drupol commented Dec 3, 2022

The sphinx-book-theme has been updated, we will need to update this soon: executablebooks/sphinx-book-theme#592

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants