Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zim: 0.74.2 -> 0.74.3 #186657

Merged
merged 1 commit into from
Aug 16, 2022
Merged

zim: 0.74.2 -> 0.74.3 #186657

merged 1 commit into from
Aug 16, 2022

Conversation

DeeUnderscore
Copy link
Contributor

Description of changes

Changelog: https://github.com/zim-desktop-wiki/zim-desktop-wiki/blob/0.74.3/CHANGELOG.md#0743---tue-07-dec-2021

This also fixes problems with the build failing due to missing gobject-interospection. See #56943 (comment) for issue and other packages affected by this. Resolves #186451.

Also, stop double-wrapping bin/zim.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@vojta001
Copy link
Contributor

Result of nixpkgs-review pr 186657 run on x86_64-linux 1

1 package built:
  • zim

@pSub pSub merged commit 99bbbc7 into NixOS:master Aug 16, 2022
@DeeUnderscore DeeUnderscore deleted the update/zim-0.74.3 branch August 16, 2022 13:32
@layus
Copy link
Member

layus commented Sep 13, 2022

This seems to fail for me with an

Traceback (most recent call last):
  [...]
    assert Gtk
AssertionError

Gtk is not found.

Fixed by disabling dontWrapGApps. Might submit a PR at some point.

It seems that makeWrapperArgs+=("''${gappsWrapperArgs[@]}") is not completely equivalent to wrapGAppsHook effect.

@layus
Copy link
Member

layus commented Sep 13, 2022

What I do not get is what changed in the meantime. Because the version that this PR pushed works too. So some dependency must have changed somewhere. Sorry for the fuss here. This deserves a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ZIM not building on NIXOS unstable 22.11pre398861.36cc29d837e (Raccoon)
4 participants