Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uboot: Copy additional DT property for pi400 PHY #185905

Closed

Conversation

karthanistyr
Copy link

@karthanistyr karthanistyr commented Aug 10, 2022

The kernel would not be able to enable the ethernet PHY device because of a discrepancy between the actual PHY address as provided by the firmware and the address specified in the kernel DTB for the Pi 400 rev 1.1.

This additional patch builds on the previous one, carrying over the relevant property.

Signed-off-by: Antoine Mazeas [email protected]

Description of changes

Adds an additional DT property copy for the ethernet-phy@1 reg value from the firmware device tree into the loaded device tree.
Hopefully this fixes #183019

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

THe kernel would not be able to enable the ethernet PHY device because of a discrepancy between the actual PHY address as provided by the firmware and the address specified in the kernel DTB for the Pi 400.

This additional patch builds on the previous one, carrying over the relevant property.

Signed-off-by: Antoine Mazeas <[email protected]>
@ofborg ofborg bot requested review from samueldr, lopsided98 and dezgeg August 10, 2022 13:12
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Aug 10, 2022
@karthanistyr
Copy link
Author

for the record, here's the upstream patch (pending review) https://patchwork.ozlabs.org/project/uboot/list/?series=313278

@karthanistyr karthanistyr mentioned this pull request Aug 16, 2022
13 tasks
@karthanistyr
Copy link
Author

Resent to u-boot for lack of feedback… https://patchwork.ozlabs.org/project/uboot/list/?series=314524

@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
@K900
Copy link
Contributor

K900 commented Jul 13, 2023

The patches got accepted upstream and are part of uboot 2023.07, nixpkgs update in #227947. Closing this as superseded. Thank you so much for your work with upstream!

@K900 K900 closed this Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Raspberrypi 400: eth0: failed to connect to PHY
3 participants