Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opam: remove aspcud from runtime #185345

Merged
merged 1 commit into from
Aug 6, 2022
Merged

Conversation

ylh
Copy link
Contributor

@ylh ylh commented Aug 6, 2022

Description of changes

see title (& appeased a strictness warning in opam.nix.pl); motivation:

  • per opam docs:
    • external solvers have not been the default recommendation since 1.2.2
    • opam will detect supported solvers at runtime for those with (what are now considered) niche use cases
  • drop a transitive build dependency on scons

result of nixpkgs-review --rev HEAD:

2 packages built:
dune-release opam

cursory test drive shows that opam still resolves dependencies perfectly competently

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Copy link
Member

@henrytill henrytill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@marsam marsam merged commit cff7b91 into NixOS:master Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants