Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beets: fix pygobject issues #184871

Merged
merged 2 commits into from
Aug 9, 2022
Merged

Conversation

pimeys
Copy link
Contributor

@pimeys pimeys commented Aug 2, 2022

Description of changes

Fixes: #184175

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@pimeys pimeys force-pushed the beets-pygobject-fixes branch from 5199388 to 6f31ea1 Compare August 3, 2022 15:49
@pimeys
Copy link
Contributor Author

pimeys commented Aug 3, 2022

Would it make sense to add a test in this PR so this will not break again?

@pimeys pimeys force-pushed the beets-pygobject-fixes branch from 6f31ea1 to caf4658 Compare August 3, 2022 21:52
@pimeys
Copy link
Contributor Author

pimeys commented Aug 3, 2022

I added a simple test, using beets with the problematic configuration.

Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for a late review.

pkgs/tools/audio/beets/common.nix Outdated Show resolved Hide resolved
pkgs/tools/audio/beets/common.nix Outdated Show resolved Hide resolved
pkgs/tools/audio/beets/common.nix Outdated Show resolved Hide resolved
@pimeys pimeys force-pushed the beets-pygobject-fixes branch from caf4658 to bd0a5ce Compare August 8, 2022 17:03
@pimeys pimeys requested a review from doronbehar August 8, 2022 17:03
@doronbehar doronbehar merged commit 8ab2469 into NixOS:master Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

beets: replaygain gstreamer setup broken on unstable and master
3 participants