-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
calamares: fix locale errors and update #184061
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
8.has: module (update)
This PR changes an existing module in `nixos/`
labels
Jul 31, 2022
ofborg
bot
added
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin
10.rebuild-linux: 501+
10.rebuild-linux: 5001+
labels
Jul 31, 2022
nixos/modules/installer/cd-dvd/installation-cd-graphical-calamares.nix
Outdated
Show resolved
Hide resolved
vlinkz
force-pushed
the
calamaresnetcheck
branch
from
September 13, 2022 19:50
789c83e
to
226c0ac
Compare
I left this on the back burner for too long. Should fix issues with unstable ISO for now, but some major changes will be needed to the patches once calamares 3.3.x is released in a few months |
This PR rebuilds a lot of packages which means we must target staging. Please follow the contributing guide to not potentially ping a lot of people. @ofborg eval |
The newer version has not been published to PyPi in two days, so Git seems to be the more reliable channel to pull this package from.
vlinkz
requested review from
ttuegel,
matthewbauer,
LnL7,
marsam,
FRidh,
a team,
Ericson2314,
nbp and
infinisil
as code owners
September 26, 2022 14:25
github-actions
bot
added
6.topic: GNOME
GNOME desktop environment and its underlying platform
6.topic: golang
6.topic: lua
6.topic: python
6.topic: qt/kde
6.topic: ruby
6.topic: rust
6.topic: stdenv
Standard environment
6.topic: systemd
6.topic: TeX
Issues regarding texlive and TeX in general
6.topic: vim
labels
Sep 26, 2022
13 tasks
ofborg
bot
added
10.rebuild-darwin-stdenv
This PR causes stdenv to rebuild
10.rebuild-linux-stdenv
This PR causes stdenv to rebuild
8.has: clean-up
8.has: package (new)
This PR adds a new package
10.rebuild-darwin: 501+
10.rebuild-darwin: 5001+
and removed
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin
labels
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: GNOME
GNOME desktop environment and its underlying platform
6.topic: golang
6.topic: lua
6.topic: nixos
Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
6.topic: python
6.topic: qt/kde
6.topic: ruby
6.topic: rust
6.topic: stdenv
Standard environment
6.topic: systemd
6.topic: TeX
Issues regarding texlive and TeX in general
6.topic: vim
8.has: clean-up
8.has: module (update)
This PR changes an existing module in `nixos/`
8.has: package (new)
This PR adds a new package
10.rebuild-darwin: 501+
10.rebuild-darwin: 5001+
10.rebuild-darwin-stdenv
This PR causes stdenv to rebuild
10.rebuild-linux: 501+
10.rebuild-linux: 5001+
10.rebuild-linux-stdenv
This PR causes stdenv to rebuild
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Changes that fix the calamares installer on unstable, update versions, and add more stability by adding a backup network check url.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes