Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python310Packages.etils: init at 0.6.0 #183052

Merged
merged 1 commit into from
Aug 6, 2022

Conversation

mcwitt
Copy link
Contributor

@mcwitt mcwitt commented Jul 27, 2022

Description of changes

Adds https://github.com/google/etils.

Initial motivation is that this is a dependency of jax>=0.3.14. This is a dependency of #183051.

Note: the derivation was contributed by @mweinelt (commit)

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@mcwitt mcwitt marked this pull request as ready for review July 27, 2022 04:02
@mcwitt mcwitt changed the title python3Packages.etils: init at 0.6.0 python310Packages.etils: init at 0.6.0 Jul 27, 2022
@mcwitt mcwitt force-pushed the squashed/init-etils branch 3 times, most recently from 20532dc to 643cb26 Compare July 30, 2022 01:49
@SuperSandro2000
Copy link
Member

@ofborg build python310Packages.etils

@SuperSandro2000
Copy link
Member

tests are failing. Please fix them.

@mcwitt
Copy link
Contributor Author

mcwitt commented Aug 1, 2022

tests are failing. Please fix them.

I think this is because jax is currently broken on master: #183173. I can bump this when the jax issue is resolved.

@samuela
Copy link
Member

samuela commented Aug 5, 2022

Just merged #185078 to fix jax. If you rebase on top of that I think you should be good to go now!

@SuperSandro2000
Copy link
Member

@ofborg build python310Packages.etils

@SuperSandro2000
Copy link
Member

Fails to build because tensorflow fails to build.

@mcwitt
Copy link
Contributor Author

mcwitt commented Aug 5, 2022

Fails to build because tensorflow fails to build.

Opened #185273

@samuela
Copy link
Member

samuela commented Aug 5, 2022

Maybe we should just merge this with tests disabled to unblock this PR, and then come back and re-enable tests once tensorflow is fixed?

@mcwitt
Copy link
Contributor Author

mcwitt commented Aug 6, 2022

Maybe we should just merge this with tests disabled to unblock this PR, and then come back and re-enable tests once tensorflow is fixed?

@samuela that sounds good to me. I went ahead and pushed a version with the tests disabled in case we decide to go ahead and merge.

@samuela
Copy link
Member

samuela commented Aug 6, 2022

Result of nixpkgs-review pr 183052 run on x86_64-linux 1

2 packages built:
  • python310Packages.etils
  • python39Packages.etils

@samuela samuela merged commit 0c60eb3 into NixOS:master Aug 6, 2022
@samuela
Copy link
Member

samuela commented Aug 6, 2022

Thanks @mcwitt ! This should help unblock us with the JAX upgrade and then we can come back and re-enable tests once that becomes possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants