-
-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python310Packages.etils: init at 0.6.0 #183052
Conversation
20532dc
to
643cb26
Compare
643cb26
to
864b347
Compare
864b347
to
b5e48a1
Compare
@ofborg build python310Packages.etils |
tests are failing. Please fix them. |
I think this is because |
Just merged #185078 to fix jax. If you rebase on top of that I think you should be good to go now! |
b5e48a1
to
f7d62f4
Compare
@ofborg build python310Packages.etils |
Fails to build because tensorflow fails to build. |
Opened #185273 |
Maybe we should just merge this with tests disabled to unblock this PR, and then come back and re-enable tests once tensorflow is fixed? |
f7d62f4
to
07ed3ff
Compare
@samuela that sounds good to me. I went ahead and pushed a version with the tests disabled in case we decide to go ahead and merge. |
Result of 2 packages built:
|
Thanks @mcwitt ! This should help unblock us with the JAX upgrade and then we can come back and re-enable tests once that becomes possible |
Description of changes
Adds https://github.com/google/etils.
Initial motivation is that this is a dependency of jax>=0.3.14. This is a dependency of #183051.
Note: the derivation was contributed by @mweinelt (commit)
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes