Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

termscp: 0.8.2 -> 0.9.0 #182947

Merged
merged 1 commit into from
Aug 10, 2022
Merged

termscp: 0.8.2 -> 0.9.0 #182947

merged 1 commit into from
Aug 10, 2022

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Jul 26, 2022 •
edited
Loading

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from fabaff July 26, 2022 10:12
@viraptor
Copy link
Contributor

Result of nixpkgs-review pr 182947 run on x86_64-darwin 1

1 package failed to build:
  • termscp
The following warnings were emitted during compilation:

warning: In file included from objc/notify.m:1:
warning: objc/notify.h:1:9: fatal error: 'Cocoa/Cocoa.h' file not found
warning: #import <Cocoa/Cocoa.h>
warning:         ^~~~~~~~~~~~~~~
warning: 1 error generated.

error: failed to run custom build command for `mac-notification-sys v0.5.0`

@viraptor
Copy link
Contributor

After adding Cocoa to the inputs:

       >   = note: Undefined symbols for architecture x86_64:
       >             "_OBJC_CLASS_$_NSImage", referenced from:
       >                 objc-class-ref in libmac_notification_sys-2ac3330293fe41fe.rlib(notify.o)
       >           ld: symbol(s) not found for architecture x86_64

@ofborg ofborg bot added 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Jul 26, 2022
@viraptor
Copy link
Contributor

Cocoa also needs to be added to all-packages.nix

@viraptor
Copy link
Contributor

Seems to be the same issue as #160876 (comment) but no solution is found there. I'll see if forcing linking AppKit will work.

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jul 26, 2022
viraptor
viraptor reviewed Jul 26, 2022
View reviewed changes
Copy link
Contributor

@viraptor viraptor left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These suggestions fix intel darwin compilation for me. I don't have an arm darwin to check, but it may need some other fixups.

pkgs/tools/networking/termscp/default.nix Show resolved Hide resolved
pkgs/tools/networking/termscp/default.nix Show resolved Hide resolved
pkgs/top-level/all-packages.nix Show resolved Hide resolved
pkgs/tools/networking/termscp/default.nix Show resolved Hide resolved
@fgaz @viraptor
termscp: 0.8.2 -> 0.9.0
1a322c8 
Co-authored-by: Stanisław Pitucha <[email protected]>
viraptor
viraptor approved these changes Jul 26, 2022
View reviewed changes
Copy link
Contributor

@viraptor viraptor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 182947 run on x86_64-darwin 1

1 package built:
  • termscp

works

@smancill smancill added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jul 27, 2022
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/575

@SuperSandro2000 SuperSandro2000 merged commit 86268b0 into NixOS:master Aug 10, 2022
@fgaz fgaz deleted the termscp/0.9.0 branch August 10, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viraptor viraptor viraptor approved these changes

@fabaff fabaff Awaiting requested review from fabaff

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fgaz @viraptor @nixos-discourse @smancill @SuperSandro2000