Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/device-tree: Use configfile when building dtbs #181063

Closed
wants to merge 1 commit into from
Closed

nixos/device-tree: Use configfile when building dtbs #181063

wants to merge 1 commit into from

Conversation

dramforever
Copy link
Contributor

@dramforever dramforever commented Jul 11, 2022 •
edited
Loading

Description of changes

This way all dtbs are built even if they are gated behind some config. Otherwise adding overlays may result in the desired dtbs missing.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jul 11, 2022
@dramforever dramforever marked this pull request as draft July 11, 2022 08:11
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jul 11, 2022
@dramforever
nixos/device-tree: Use configfile when building dtbs
27606b3 
We rebuild dtbs for applying overlays, but some of the dtbs are enabled
by configs. Use kernelPackage.configfile instead of to ensure that these
dtbs work with overlays.
@dramforever dramforever marked this pull request as ready for review July 11, 2022 08:26
@dramforever dramforever changed the title nixos/device-tree: Use allyesconfig when building dtbs nixos/device-tree: Use configfile when building dtbs Jul 11, 2022
@dramforever
Copy link
Contributor Author

Pinging some people from #79370: @sorki @samueldr. Hope this the right way to ask for reviews.

sorki
sorki approved these changes Jul 21, 2022
View reviewed changes
Copy link
Member

@sorki sorki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. Thank you!

@mweinelt mweinelt added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jul 22, 2022
@lovesegfault
Copy link
Member

@dramforever Can you rebase this?

@dramforever
Copy link
Contributor Author

Actually I can't. This PR is subsumed by #187252 and is no longer relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorki sorki sorki approved these changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dramforever @lovesegfault @sorki @mweinelt