Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/alps: init module #180598

Merged
merged 3 commits into from
Sep 17, 2022
Merged

nixos/alps: init module #180598

merged 3 commits into from
Sep 17, 2022

Conversation

madonius
Copy link

@madonius madonius commented Jul 7, 2022

Description of changes

Added service definition for alps

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jul 7, 2022
@madonius
Copy link
Author

madonius commented Jul 7, 2022 •
edited
Loading

What is missing:

  • Service restart does not work
  • Systemd target dependency is not correct

@madonius madonius force-pushed the package/alps branch 2 times, most recently from 9e2075f to 4c1f9ea Compare July 7, 2022 22:33
@ofborg ofborg bot requested review from kalbasit, booklearner and a user July 7, 2022 23:37
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 labels Jul 7, 2022
@madonius madonius force-pushed the package/alps branch 3 times, most recently from 485fa7e to 69b252a Compare July 8, 2022 09:20
@madonius madonius marked this pull request as ready for review July 8, 2022 10:40
@madonius madonius requested a review from NickCao July 8, 2022 10:52
@NickCao
Copy link
Member

NickCao commented Jul 8, 2022 •
edited
Loading

To avoid cluttering this pr with the packaging fixes, I extracted that part into a separate pr: #180699

NickCao
NickCao reviewed Jul 8, 2022
View reviewed changes
nixos/modules/services/web-apps/alps.nix Show resolved Hide resolved
nixos/modules/services/web-apps/alps.nix Show resolved Hide resolved
nixos/modules/services/web-apps/alps.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-apps/alps.nix Outdated Show resolved Hide resolved
SuperSandro2000
SuperSandro2000 reviewed Jul 8, 2022
View reviewed changes
pkgs/servers/alps/default.nix Outdated Show resolved Hide resolved
pkgs/servers/alps/default.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-apps/alps.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-apps/alps.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-apps/alps.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-apps/alps.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-apps/alps.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-apps/alps.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-apps/alps.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-apps/alps.nix Outdated Show resolved Hide resolved
@booklearner
Copy link
Member

Thanks for adding the reviews, and thanks adding the service and adding yourself as a maintainer!

This LGTM after feedback from other reviews is applied.

@Ma27
Copy link
Member

Ma27 commented Jul 8, 2022

To avoid cluttering this pr with the packaging fixes, I extracted that part into a separate pr: #180699

I don't think that opening even more micro-PRs isn't helping. Both things are related (i.e. one depends strictly on another), so why this split-up?

@Ma27
Copy link
Member

Ma27 commented Jul 22, 2022

@madonius can we help you with pushing this forward? :)

@SuperSandro2000 SuperSandro2000 changed the title Nixos/alps: init module nixos/alps: init module Sep 16, 2022
@github-actions github-actions bot added 8.has: changelog 8.has: documentation This PR adds or changes documentation labels Sep 16, 2022
@bobby285271 bobby285271 added 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Sep 17, 2022
@SuperSandro2000 SuperSandro2000 merged commit 8ad3fe7 into NixOS:master Sep 17, 2022
hmenke
hmenke reviewed Nov 5, 2022
View reviewed changes
nixos/modules/services/web-apps/alps.nix
smtps = {
port = mkOption {
type = types.port;
default = 445;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo? The default SMTPS port is 465.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

I opened a PR to fix this: #199905

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@booklearner booklearner booklearner approved these changes

@tanneberger tanneberger tanneberger left review comments

@NickCao NickCao NickCao left review comments

@Ma27 Ma27 Ma27 left review comments

@hmenke hmenke hmenke left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@madonius @NickCao @booklearner @Ma27 @hmenke @SuperSandro2000 @tanneberger @bobby285271