Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tradcpp: move autoconf to nativeBuildInputs #178467

Merged
merged 1 commit into from
Jun 22, 2022
Merged

tradcpp: move autoconf to nativeBuildInputs #178467

merged 1 commit into from
Jun 22, 2022

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Jun 21, 2022 •
edited
Loading

Noticed as a build failure on config.strictDepsByDefault = true:

configuring
setup: line 86: autoconf: command not found
Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@trofi
tradcpp: move autoconf to nativeBuildInputs
ed60f38 
Noticed as a build failure on `config.strictDepsByDefault = true`:

    configuring
    setup: line 86: autoconf: command not found
@trofi trofi mentioned this pull request Jun 21, 2022
Open
@siraben
Copy link
Member

siraben commented Jun 21, 2022

Result of nixpkgs-review pr 178467 run on aarch64-darwin 1

@SuperSandro2000 SuperSandro2000 merged commit 8c5a263 into NixOS:master Jun 22, 2022
@trofi trofi deleted the strictDeps-for-tradcpp branch June 22, 2022 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mindavi Mindavi Mindavi approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trofi @siraben @Mindavi @SuperSandro2000