Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jellyfin-ffmpeg: 4.4.1-4 -> 5.0.1-5 #176426

Merged
merged 1 commit into from
Jun 9, 2022
Merged

jellyfin-ffmpeg: 4.4.1-4 -> 5.0.1-5 #176426

merged 1 commit into from
Jun 9, 2022

Conversation

Kranzes
Copy link
Member

@Kranzes Kranzes commented Jun 5, 2022

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@Kranzes
Copy link
Member Author

Kranzes commented Jun 5, 2022

Result of nixpkgs-review pr 176426 run on x86_64-linux 1

1 package failed to build:
  • jellyfin
1 package built:
  • jellyfin-ffmpeg

@Kranzes
Copy link
Member Author

Kranzes commented Jun 5, 2022

Jellyfin's build failure is unrelated. See #176288

@Kranzes Kranzes requested a review from justinas June 5, 2022 17:27
justinas
justinas approved these changes Jun 5, 2022
View reviewed changes
Copy link
Member

@justinas justinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Not sure how the upstream maintains the compatibility between this and Jellyfin proper, does this need to be merged in sync with #144082 when the 10.8 stable is out?

@ofborg ofborg bot requested a review from justinas June 5, 2022 17:35
@Kranzes
Copy link
Member Author

Kranzes commented Jun 5, 2022

I don't think they need to be in sync. This should be compatible with the stable Jellyfin release since this ffmpeg release is also a stable one. They expect you to be using it with the stable release of Jellyfin.

@Artturin Artturin added 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Jun 6, 2022
@Kranzes
Copy link
Member Author

Kranzes commented Jun 9, 2022

Result of nixpkgs-review pr 176426 run on x86_64-linux 1

2 packages built:
  • jellyfin
  • jellyfin-ffmpeg

@Kranzes Kranzes requested a review from SuperSandro2000 June 9, 2022 18:27
@SuperSandro2000 SuperSandro2000 merged commit 435a735 into NixOS:master Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinas justinas justinas approved these changes

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kranzes @justinas @SuperSandro2000 @Artturin