Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grapejuice: 4.10.2 -> 5.1.1 #176384

Merged
merged 1 commit into from
Jun 10, 2022
Merged

grapejuice: 4.10.2 -> 5.1.1 #176384

merged 1 commit into from
Jun 10, 2022

Conversation

helium18
Copy link
Contributor

@helium18 helium18 commented Jun 5, 2022 •
edited
Loading

Description of changes

Update grapejuice from 4.10.2 to 5.1.1
Required compiling of locales and adding wine64 (grapejuice requires both wine and wine64)

Edit: Using wineWow instead of wine and wine64

Grapejuice changelog: https://gitlab.com/brinkervii/grapejuice/-/releases/v5.1.1

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@helium18 helium18 force-pushed the master branch 2 times, most recently from 108a5e7 to c93ad00 Compare June 5, 2022 12:03
@helium18 helium18 requested a review from Artturin June 5, 2022 12:04
@Artturin
Copy link
Member

Artturin commented Jun 5, 2022

Try wineWow instead of wine,wine64

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jun 5, 2022
@helium18
Copy link
Contributor Author

helium18 commented Jun 5, 2022

According to BrinkerVII, xrandr is optional and it doesn't work on Wayland, so grapejuice falls back to info from lspci. I'm replacing xrandr with pciutils (still builds and works fine)

@helium18 helium18 force-pushed the master branch 2 times, most recently from 65bf773 to fd158e6 Compare June 5, 2022 16:18
@ofborg ofborg bot requested a review from Artturin June 5, 2022 16:24
@helium18
Copy link
Contributor Author

helium18 commented Jun 5, 2022

Adding glxinfo which helps grapejuice guess the opengl capabilities of the system

@Artturin Artturin merged commit b03082a into NixOS:master Jun 10, 2022
@Artturin Artturin mentioned this pull request Mar 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Artturin Artturin Awaiting requested review from Artturin

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@helium18 @Artturin