crystal: 1.2 -> 1.4

[Artturin]

Description of changes

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.05 Release Notes (or backporting 21.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[Artturin]

both crystal_1_3 and crystal_1_4 fail to build with this error

crystal> Failures:
crystal>   1) Crystal::FFI::CallInterface .new sum struct
crystal>      Failure/Error: pointer_value.should eq 50
crystal>        Expected: 50
crystal>             got: 0
crystal>      # spec/compiler/ffi/ffi_spec.cr:165
crystal>   2) Crystal::Loader dynlib #load_library does not implicitly find dependencies
crystal>        cannot find -lbar (/build/cr-spec-ca56a4a7/loader/libbar.so: undefined symbol: foo) (Crystal::Loader::LoadError)
crystal>          from src/compiler/crystal/loader/unix.cr:82:54 in 'load_library'
crystal>          from spec/compiler/loader/unix_spec.cr:123:7 in '->'
crystal>          from src/spec/example.cr:45:13 in 'internal_run'
crystal>          from src/spec/example.cr:33:16 in 'run'
crystal>          from src/spec/context.cr:18:23 in 'internal_run'
crystal>          from src/spec/context.cr:337:14 in 'run'
crystal>          from src/spec/context.cr:18:23 in 'internal_run'
crystal>          from src/spec/context.cr:337:14 in 'run'
crystal>          from src/spec/context.cr:18:23 in 'internal_run'
crystal>          from src/spec/context.cr:337:14 in 'run'
crystal>          from src/spec/context.cr:18:23 in '->'
crystal>          from src/array.cr:1273:5 in 'main'
crystal>          from /nix/store/bvy2z17rzlvkx2sj7fy99ajm853yv898-glibc-2.34-210/lib/libc.so.6 in '??'
crystal>          from /nix/store/bvy2z17rzlvkx2sj7fy99ajm853yv898-glibc-2.34-210/lib/libc.so.6 in '__libc_start_main'
crystal>          from ../sysdeps/x86_64/start.S:118 in '_start'
crystal>          from ???
crystal>
crystal> Finished in 6:12 minutes
crystal> 10446 examples, 1 failures, 1 errors, 15 pending
crystal> Failed examples:
crystal> crystal spec spec/compiler/ffi/ffi_spec.cr:131 # Crystal::FFI::CallInterface .new sum struct
crystal> crystal spec spec/compiler/loader/unix_spec.cr:123 # Crystal::Loader dynlib #load_library does not implicitly find dependencies
crystal> make: *** [Makefile:108: compiler_spec] Error 1
note: keeping build directory '/comp-temp/nix-build-crystal-1.4.1.drv-6'

[peterhoeg]

Did you manage to get any further with this?

[peterhoeg]

close as we have #195606