Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkgsStatic.perl: fix build #171854

Merged
merged 1 commit into from
May 9, 2022
Merged

pkgsStatic.perl: fix build #171854

merged 1 commit into from
May 9, 2022

Conversation

alyssais
Copy link
Member

@alyssais alyssais commented May 6, 2022

Description of changes

This perl-cross upgrade brings in a single new commit, by me, that
fixes the pkgsStatic.perl build (which was broken by #167084).

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@alyssais
pkgsStatic.perl: fix build
4761e50 
This perl-cross upgrade brings in a single new commit, by me, that
fixes the pkgsStatic.perl build.

Fixes: d1adf50 ("perl: use pkgs.zlib instead of bundled zlib")
@alyssais alyssais requested review from stigtsp and zakame as code owners May 6, 2022 19:48
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels May 6, 2022
@zakame
Copy link
Member

zakame commented May 7, 2022

@ofborg build pkgsStatic.perl pkgsStatic.aarch64-multiplatform.perl

zakame
zakame approved these changes May 7, 2022
View reviewed changes
Copy link
Member

@zakame zakame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, looks it it builds fine! 🎉 💯

stigtsp
stigtsp reviewed May 8, 2022
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice with a mention in the commit title that perl-cross is bumped from 1.3.7 to 31dac3e2, other than that LGTM

stigtsp
stigtsp approved these changes May 9, 2022
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But no reason to hold up the merge, LGTM

@stigtsp stigtsp merged commit 8a22e5f into NixOS:master May 9, 2022
@alyssais alyssais deleted the lddlflags branch June 9, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zakame zakame zakame approved these changes

@stigtsp stigtsp stigtsp approved these changes

Assignees
No one assigned
Labels
6.topic: static 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alyssais @zakame @stigtsp @Mindavi