curl: gate darwin workarounds behind stdenv.isDarwin to make life on linux easier

[SuperSandro2000]

…

Closes #3382

Description of changes

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.05 Release Notes (or backporting 21.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[FRidh]

I prefer patching only those that are affected as well, however, I know there are those that have a different view. Their view is to apply it for everyone because that way you can detect easily when a patch does not apply anymore and it will more likely be fixed.

[thiagokokada]

Wouldn't it be better to use stdenv.hostPlatform.isDarwin instead to take care of the cross-compiling cases here?

[SuperSandro2000]

isDarwin is an alias to hostPlatform.isDarwin https://github.com/nix-community/home-manager/blob/master/tests/default.nix#L35-L36

[thiagokokada]

I prefer patching only those that are affected as well, however, I know there are those that have a different view. Their view is to apply it for everyone because that way you can detect easily when a patch does not apply anymore and it will more likely be fixed.

Not related to this PR, but I think we need to have a clearer instance about Darwin.

It is clearly a "best effort" platform that causes tons of headaches thanks to the inability of Apple of supplying good sources where we can base our stdenv on, that is also constantly changing and breaking things at each update making each upgrade a mess.

Not criticizing the excellent work of the Darwin maintainers, but it really is a platform that is a PITA to work with.

[SuperSandro2000]

I prefer patching only those that are affected as well, however, I know there are those that have a different view. Their view is to apply it for everyone because that way you can detect easily when a patch does not apply anymore and it will more likely be fixed.

Normally this is the case but since the flags make the linux experience actually worse I think we can make an exception here.