Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nwg-look: init at 0.1.2 #169251

Closed
wants to merge 2 commits into from
Closed

nwg-look: init at 0.1.2 #169251

wants to merge 2 commits into from

Conversation

bnhrkn
Copy link

@bnhrkn bnhrkn commented Apr 19, 2022

Description of changes

Add nwg-look, a wayland / wlroots replacement for lxappearance and add myself to maintainers list.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Apr 19, 2022
@ofborg ofborg bot requested a review from kalbasit April 19, 2022 01:56
@ghishadow ghishadow mentioned this pull request Apr 19, 2022
Closed
@bnhrkn bnhrkn marked this pull request as draft April 26, 2022 13:41
@bnhrkn
Copy link
Author

bnhrkn commented Apr 28, 2022

On further testing, the application fails because it can't write to ~/.config/gtk-3.0/settings.ini which is a symlink into the nix store. Not sure how to go about fixing that problem.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 30, 2022
@lf-
Copy link
Member

lf- commented Dec 4, 2022

We've tested this and it's stuck at Building subPackage .

@lf-
Copy link
Member

lf- commented Dec 4, 2022 •
edited
Loading

ah, no it's building gtk, and it's doing it on one core. that's wildly bad. By the way if you update this patch to 0.1.4 it will Just Work, seemingly!

@lf-
Copy link
Member

lf- commented Dec 4, 2022

😭 golang/go#9887

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Dec 4, 2022
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
@AndersonTorres
Copy link
Member

#246601

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bnhrkn @lf- @AndersonTorres @Janik-Haag