cjdns: don't set -Wno-error=stringop-overread with gcc<11 #168997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build would error out on aarch64-linux with > cc1: error: '-Werror=stringop-overread': no option -Wstringop-overread
ofborg
bot
added
10.rebuild-darwin: 0
admin-turris
pushed a commit
to turris-cz/os-build
that referenced
this pull request
Nov 3, 2023
…version 11 Added condition to remove -Wno_overread warning if toolchain is lower than version 11, based on recommendation (NixOS/nixpkgs#168997) Added two patches from OpenWrt feed. python-3.10-patch (1df5290b92625823bb9725a5406383116463f3ac) invalid-pointer (d710a7938977c84d6ea0f74b21dc50111e5e968c)
admin-turris
pushed a commit
to turris-cz/os-build
that referenced
this pull request
Nov 27, 2023
…version 11 Added condition to remove -Wno_overread warning if toolchain is lower than version 11, based on recommendation (NixOS/nixpkgs#168997) Added two patches from openwrt stream. patch3.10 (1df5290b92625823bb9725a5406383116463f3ac) invalid-pointer (d710a7938977c84d6ea0f74b21dc50111e5e968c) In previous patch there was error with empty intcmp. This commit fix error in in 26c38a1 Rename TARGET_CCFLAGS to EXTRA_TARGET_CFLAGS, because TARGET_CCFLAGS is for C++ stuff.
admin-turris
pushed a commit
to turris-cz/os-build
that referenced
this pull request
Jul 3, 2024
Added condition to remove -Wno_overread warning if toolchain is lower than version 11, based on recommendation (NixOS/nixpkgs#168997) Added two patches from openwrt stream. patch3.10 (1df5290b92625823bb9725a5406383116463f3ac) invalid-pointer (d710a7938977c84d6ea0f74b21dc50111e5e968c) In previous patch there was error with empty intcmp. This commit fix error in in 26c38a1 Rename TARGET_CCFLAGS to EXTRA_TARGET_CFLAGS, because TARGET_CCFLAGS is for C++ stuff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build would error out on aarch64-linux with
Description of changes
Not sure if this is the correct way to handle this problem.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes