Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

starship: use unstable to fix darwin #168558

Merged
merged 1 commit into from
Apr 14, 2022

Conversation

happysalada
Copy link
Contributor

Description of changes

This switches to unstable for a quick fix for darwin.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@happysalada
Copy link
Contributor Author

I'm going to merge this since ci is passing.
Happy to take care of feedback if there is anything.

@happysalada happysalada merged commit b2070af into NixOS:master Apr 14, 2022
@happysalada happysalada deleted the starship_fix_darwin branch April 14, 2022 00:52
@siraben
Copy link
Member

siraben commented Apr 14, 2022

Result of nixpkgs-review pr 168558 run on aarch64-darwin 1

1 package built:
  • starship

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants