Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gzip: 1.11 -> 1.12 #167784

Merged
merged 1 commit into from
Apr 10, 2022
Merged

gzip: 1.11 -> 1.12 #167784

merged 1 commit into from
Apr 10, 2022

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Apr 7, 2022

https://savannah.gnu.org/forum/forum.php?forum_id=10157
https://git.savannah.gnu.org/cgit/gzip.git/commit/?id=dc9740df61e575e8c3148b7bd3c147a81ea00c7c

Fixes: CVE-2022-1271

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@mweinelt mweinelt added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Apr 7, 2022
@mweinelt mweinelt changed the base branch from master to staging April 7, 2022 23:03
@mweinelt
Copy link
Member Author

mweinelt commented Apr 8, 2022

@ofborg eval

@mweinelt
Copy link
Member Author

mweinelt commented Apr 8, 2022

Go home ofborg, you're drunk. Use another mirror already.

@mweinelt
Copy link
Member Author

mweinelt commented Apr 8, 2022

@ofborg eval

@vcunat vcunat changed the base branch from staging to staging-next April 10, 2022 09:43
@vcunat vcunat merged commit f93fdb8 into NixOS:staging-next Apr 10, 2022
@github-actions github-actions bot mentioned this pull request Apr 10, 2022
Merged
1 task
@github-actions
Copy link
Contributor

Successfully created backport PR #168117 for staging-21.11.

@mweinelt mweinelt deleted the gzip branch April 10, 2022 11:06
@risicle
Copy link
Contributor

risicle commented Apr 10, 2022

(managed to build a lot of the macos 10.15 stdenv with this without problems)

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild 10.rebuild-linux-stdenv This PR causes stdenv to rebuild 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ labels Apr 10, 2022
@github-actions
Copy link
Contributor

Backport failed for staging-21.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin staging-21.11
git worktree add -d .worktree/backport-167784-to-staging-21.11 origin/staging-21.11
cd .worktree/backport-167784-to-staging-21.11
git checkout -b backport-167784-to-staging-21.11
ancref=$(git merge-base 1ebc1944ed5726c871f9af43ad7fae42e673cf4f c4d4de89ddac3e11f4c0e4b3c9f6bd074796cbb3)
git cherry-pick -x $ancref..c4d4de89ddac3e11f4c0e4b3c9f6bd074796cbb3

1 similar comment
@github-actions
Copy link
Contributor

Backport failed for staging-21.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin staging-21.11
git worktree add -d .worktree/backport-167784-to-staging-21.11 origin/staging-21.11
cd .worktree/backport-167784-to-staging-21.11
git checkout -b backport-167784-to-staging-21.11
ancref=$(git merge-base 1ebc1944ed5726c871f9af43ad7fae42e673cf4f c4d4de89ddac3e11f4c0e4b3c9f6bd074796cbb3)
git cherry-pick -x $ancref..c4d4de89ddac3e11f4c0e4b3c9f6bd074796cbb3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mweinelt @risicle @vcunat