python39Packages.pycurl: disable failing tests, add SuperSandro2000 as maintainer

[SuperSandro2000]

Description of changes

I want to test the click fallout and noticed that the tests are failing.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.05 Release Notes (or backporting 21.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[SuperSandro2000]

@ofborg eval

[dtzWill]

Do we know why these are failing? Should issues be reported upstream?

[andrevmatos]

Can this be fast-tracked to master? system-config-printer/cups setups seems broken by this on current nixos-unstable-small

[SuperSandro2000]

Do we know why these are failing? Should issues be reported upstream?

no, didn't look into and the error message is not helpful.

---

Can this be fast-tracked to master? system-config-printer/cups setups seems broken by this on current nixos-unstable-small

@mweinelt @jonringer any opinions on that?

[mweinelt]

Can you use http://localhost:631 in the meantime?

[peterhoeg]

The tests are probably failing due to the root CA certs not being available in the build environment and the certificate chain thus not being verifiable. This is just guesswork based on the name of the tests but probably worth checking out.

[Shawn8901]

Can you use http://localhost:631 in the meantime?

i did disable the tests in a fork until the PR gets to master. i dont see any issues related to CUPS. The web interface, and also KDEs printer frontend in the system settings, work without issues on my side.

2nd edit: i am on NIXOS/unstables eval on b6966d9

next edit: ofc with out this PR its not usable / its not working like andrevmatos mentioned as system is not buildable

[andrevmatos]

Can you use http://localhost:631 in the meantime?

No, because the system fails to even build without this PR's patch. Just enabling cups (to use it at all) pulls in system-config-printer, which depends on pycurl as builtInput, which then fails to build and prevents the whole system's derivation from building. Workaround is to disable services.printing, or to pull in this patch manually.

[vkraven]

... Workaround is to disable services.printing, or to pull in this patch manually.

When you say "pull in this patch manually" for a dependency of system-config-printer, do you mean to 1) clone nixpkgs, 2) patch it there, and then 3) point nix-channel to this local copy as <nixpkgs>?

Sorry for the newbie question, still getting familiar with Nix here. system.replaceRuntimeDependencies didn't seem to do it for me.

[gador]

The tests are failing due to upstream error in curl:
curl/curl#8582

I think we shouldn't merge this and instead fix curl

[PaulGrandperrin]

Here's my PR with the proper patch: #167993

[andrevmatos]

When you say "pull in this patch manually" for a dependency of system-config-printer, do you mean to 1) clone nixpkgs, 2) patch it there, and then 3) point nix-channel to this local copy as <nixpkgs>?

Yes, this is an option. What I do instead is to use flake-utils-plus and use patches option to patch a flake input on-the-fly, way easier to test new PRs and pull in these quick fixes.

[PaulGrandperrin]

When you say "pull in this patch manually" for a dependency of system-config-printer, do you mean to 1) clone nixpkgs, 2) patch it there, and then 3) point nix-channel to this local copy as <nixpkgs>?

Yes, this is an option. What I do instead is to use flake-utils-plus and use patches option to patch a flake input on-the-fly, way easier to test new PRs and pull in these quick fixes.

You can also use an overlay like this:

final: prev: { curl = prev.curl.overrideAttrs (oldAttrs: {
      patches = oldAttrs.patches ++ [ ./7.82.0-openssl-fix-CN-check.patch ];
    }); };

[linminhtoo]

I'm a complete noob at using NixOS. I'm facing this exact same error as mentioned by this post https://githubhot.com/repo/NixOS/nixpkgs/issues/167579

What do I do as a user of NixOS to fix this ?

[PaulGrandperrin]

@linminhtoo the fix is not available yet on cache.nixos.org.
When I try to use this patch myself (cloning nixpkgs or using the above overlay), it triggers a huge recompilation... so it's not usable...

So you can:

• wait for nixos-unstable to be updated with the patch
• temporarily disable services.printing (which is probably what depends on this package)

[linminhtoo]

I see, thanks. disabling services.printing does fix the issue for now.

@linminhtoo the fix is not available yet on cache.nixos.org. When I try to use this patch myself (cloning nixpkgs or using the above overlay), it triggers a huge recompilation... so it's not usable...

So you can:

• wait for nixos-unstable to be updated with the patch
• temporarily disable services.printing (which is probably what depends on this package)