-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
devito: init at unstable-2022-04-22 #165484
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thx for the review! |
The packages should have |
Oh I sincerily forgot, I gonna fix that right away. Btw, do you know a way for me to ammend previous commits without messing up the tree? |
You could do an interactive rebase: $ git rebase -i master Then mark all of the commits |
Thx, gonna try it! |
Ok, I think I covered almost all of the requests. What is left is running the tests. |
9c40e47
to
de15125
Compare
@SuperSandro2000 have you taken a look into the test errors for devito too, in the pastebin I linked? Should I set doCheck=false too for them? |
Oh, forgot that. I don't know mpi or how to fix the error.
I would suggest to add the 4 tests to |
Well, there are many tests that use MPI, these 4 tests are just the ones whom failed first since it stops with 5 failures. Maybe I can map all the ones that do use it, it will take some time though. |
Some testing is always better than none. |
3525b60
to
f7ae845
Compare
@SuperSandro2000 ping |
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 2 packages failed to build and are new build failures:
6 packages built:
The following issues got detected with the above build packages.
python310Packages.contexttimer:
A typo in pythonImportsCheck got detected. A typo in pythonImportsCheck got detected. |
Strange, it built successfully on my machine. It wil be kind of hard to reproduce the error. |
nixpkgs review merges the branch into master. Try |
I managed to reproduce the error, seems like a problem with sympy. I have zero ideas of how to solve this issue apart from forcing the usage of an older version of sympy through an overlay. |
Maybe the release notes of sympy help? https://github.com/sympy/sympy/wiki/Release-Notes-for-1.10 |
@SuperSandro2000 , it seems like the problem was resolved with the most recent updates, so I changed the derivation version to the unstable format and also wrote an update script. |
def updateRequirementsPatch(requirements,derivation): | ||
key = "distributed" | ||
lineReq = findLine(key,requirements)[0] | ||
lineDer = findLine(key,derivation)[0] | ||
derivation[lineDer] = f""" --replace "{requirements[lineReq]}" "distributed" \ \n;""" | ||
|
||
key = "flake8" | ||
lineReq = findLine(key,requirements)[0] | ||
lineDer = findLine(key,derivation)[0] | ||
derivation[lineDer] = f""" --replace "{requirements[lineReq]}" "" \ \n;""" | ||
|
||
key = "pytest" | ||
lineReq = findLine(key,requirements)[0] | ||
lineDer = findLine(key,derivation)[0] | ||
derivation[lineDer] = f""" --replace "{requirements[lineReq]}" "" \ \n;""" | ||
|
||
key = "pytest-runner" | ||
lineReq = findLine(key,requirements)[0] | ||
lineDer = findLine(key,derivation)[0] | ||
derivation[lineDer] = f""" --replace "{requirements[lineReq]}" "" \ \n;""" | ||
|
||
key = "pytest-cov" | ||
lineReq = findLine(key,requirements)[0] | ||
lineDer = findLine(key,derivation)[0] | ||
derivation[lineDer] = f""" --replace "{requirements[lineReq]}" "" \ \n;""" | ||
|
||
return derivation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be easily replaced with a one sed script that removes everything after the first match of [<>]=
and then we can scrap the entire updater script and use the unstable-updater.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be very nice to have an example haha.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SuperSandro2000 I discussed this with some colleagues, and I find that the sed approach would be too easy to break, while my update script, although I admit is a bit overengineered, it is far more robust than a sed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the script is very over engineered and as soon as it breaks the next person will most likely just remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SuperSandro2000 I adhered to your suggestions, pls do check if is ok now.
39285da
to
954a2d2
Compare
a43e9f1
to
2f17522
Compare
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 8 packages built:
|
Thank you very much for your patience @SuperSandro2000 . |
Description of changes
I implemented this package because I going to need it for my job. Devito is a domain specific language API that allows for code generation of partial differential equations solutions, and is highly optimized for both CPU and GPU.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes