Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perl: 5.34.0 -> 5.34.1, perldevel: 5.35.4 -> 5.35.9, perl.perl-cross: 393821c7 -> 1.3.7 #164301

Merged
merged 3 commits into from
Apr 8, 2022
Merged

perl: 5.34.0 -> 5.34.1, perldevel: 5.35.4 -> 5.35.9, perl.perl-cross: 393821c7 -> 1.3.7 #164301

merged 3 commits into from
Apr 8, 2022

Conversation

stigtsp
Copy link
Member

@stigtsp stigtsp commented Mar 15, 2022 •
edited
Loading

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild 10.rebuild-linux-stdenv This PR causes stdenv to rebuild labels Mar 15, 2022
@ofborg ofborg bot requested a review from edolstra March 15, 2022 21:41
@stigtsp stigtsp force-pushed the package/perl-5.34.1 branch from 85d9e0a to 00d64cc Compare March 16, 2022 13:08
@stigtsp stigtsp changed the title [wip] perl: 5.34.0 -> 5.34.1 perl: 5.34.0 -> 5.34.1, perldevel: 5.35.4 -> 5.35.9, perl.perl-cross: 393821c7 -> 1.3.7 Mar 16, 2022
@stigtsp stigtsp marked this pull request as ready for review March 16, 2022 14:43
@stigtsp stigtsp requested a review from zakame as a code owner March 16, 2022 14:43
@stigtsp stigtsp requested review from alyssais and dasJ March 16, 2022 14:44
@stigtsp
Copy link
Member Author

stigtsp commented Mar 16, 2022

@GrahamcOfBorg build pkgsCross.aarch64-multiplatform.perl534
@GrahamcOfBorg build pkgsCross.armv7l-hf-multiplatform.perl534
@GrahamcOfBorg build pkgsMusl.perl534
@GrahamcOfBorg build pkgsi686Linux.perl534
@GrahamcOfBorg build perl534

@GrahamcOfBorg build pkgsCross.aarch64-multiplatform.perlPackages.HTTPDaemon
@GrahamcOfBorg build perlPackages.DBDmysql perlPackages.IOSocketSSL
@GrahamcOfBorg build hydra-unstable

@dasJ
Copy link
Member

dasJ commented Mar 16, 2022

Personal favor of test: @GrahamcOfBorg test switchTest

stigtsp added 2 commits March 16, 2022 17:00
@stigtsp
perl.perl-cross: 393821c7 -> 1.3.7
d25a1e4 
- Update `perl-cross` to latest release which supports perl 5.34.1
- Remove patch as it's included upstream
@stigtsp
perldevel: 5.35.4 -> 5.35.9
2cf99c9
@stigtsp stigtsp force-pushed the package/perl-5.34.1 branch from d318ab5 to 2cf99c9 Compare March 16, 2022 16:03
@stigtsp
Copy link
Member Author

stigtsp commented Mar 16, 2022

@GrahamcOfBorg build pkgsCross.armv7l-hf-multiplatform.perl534
@GrahamcOfBorg build pkgsCross.aarch64-multiplatform.perl534
@GrahamcOfBorg test switchTest

@stigtsp
Copy link
Member Author

stigtsp commented Mar 16, 2022

@GrahamcOfBorg eval

@stigtsp
Copy link
Member Author

stigtsp commented Mar 17, 2022

@GrahamcOfBorg test switchTest

@stigtsp
Copy link
Member Author

stigtsp commented Mar 17, 2022

@GrahamcOfBorg build pkgsMusl.perl534
@GrahamcOfBorg build pkgsi686Linux.perl534
@GrahamcOfBorg build perl534 perldevel

@stigtsp stigtsp requested a review from vcunat April 4, 2022 12:28
zakame
zakame approved these changes Apr 4, 2022
View reviewed changes
Copy link
Member

@zakame zakame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@stigtsp
Copy link
Member Author

stigtsp commented Apr 8, 2022

@GrahamcOfBorg build perl534
@GrahamcOfBorg build perldevel
@GrahamcOfBorg test switchTest
@GrahamcOfBorg build hydra-unstable

@Lassulus Lassulus merged commit 81dc2b5 into NixOS:staging Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zakame zakame zakame approved these changes

@edolstra edolstra Awaiting requested review from edolstra

@alyssais alyssais Awaiting requested review from alyssais

@dasJ dasJ Awaiting requested review from dasJ

@vcunat vcunat Awaiting requested review from vcunat

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 10.rebuild-linux-stdenv This PR causes stdenv to rebuild
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stigtsp @dasJ @zakame @Lassulus