-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rust and cargo improvements #16052
Rust and cargo improvements #16052
Conversation
cc @wizeman |
8a27ac3
to
30d5f37
Compare
don't merge this just yet, I want to rework this. rust is moving to using cargo as a build system, so the rustc and cargo packages can share the bootstrapping code. should this be a new package then? or can we put the cargo and rustc code in the same folder so that we can share the bootstrapping code through local imports without polluting all-packages? |
I'm fine with moving |
So final building and testing is still pending, but I think it should be ok. If someone wants to test it on mac osx to make sure there are no regressions, that would be good... |
fbefb0d
to
3196059
Compare
Seems like there is an issue with evaluating the package set:
|
Also, personally, I'd like an alias for |
mmh that is right there is no build-managers cargo anymore. have you added any custom patches to nixpkgs? I'm not having that problem... I rebased on master and added a sha256 fix for the exa package, and added a rustc alias, can you try again? |
I didn't at the time. I re-applied everything after your recent rebase and now it's evaluating fine. |
I'll check if everything builds fine with sandbox . Otherwise 👍 |
|
I get these spurious hash changes sometimes too. My rust src is currently cached, so I didn't notice the change. I think fetchgit isn't 100% deterministic. |
Pushed the hash change |
Ugh, non-determinism in |
Maybe. If I would make a wild guess I'd say this happens when a submodule
|
@the-kenny I know I'm inpatient, but I'll ask anyway. Are we good to go? |
Sorry! I was busy at work yesterday (while my machine built all of Rust in Nix). To me it looks good. I think it's fine to merge it, but we should try to investigate the sha256 issue further. |
Motivation for this change
To try out rust on arm (depends on #15867):
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)