Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

secp256k1: unstable-2021-06-06 -> unstable-2022-02-06 #158516

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

L-as
Copy link
Member

@L-as L-as commented Feb 7, 2022

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@L-as
Copy link
Member Author

L-as commented Feb 7, 2022

Replaces #152639

@jonringer
Copy link
Contributor

looks like the python package breaks

https://github.com/NixOS/nixpkgs/pull/158516

3 packages failed to build:
electrum-grs python310Packages.secp256k1 python39Packages.secp256k1

15 packages built:
echidna electron-cash electrum electrum-ltc haskellPackages.hevm jami-client-gnome jami-client-qt jami-daemon jami-libclient libbitcoin libbitcoin-client libbitcoin-explorer libbitcoin-network libbitcoin-protocol secp256k1

Error:

       > Traceback (most recent call last):
       >   File "/build/secp256k1-0.14.0/nix_run_setup", line 8, in <module>
       >     exec(compile(getattr(tokenize, 'open', open)(__file__).read().replace('\\r\\n', '\\n'), __file__, 'exec'))
       >   File "setup.py", line 40, in <module>
       >     if [int(i) for i in setuptools_version.split('.')] < [3, 3]:
       >   File "setup.py", line 40, in <listcomp>
       >     if [int(i) for i in setuptools_version.split('.')] < [3, 3]:
       > ValueError: invalid literal for int() with base 10: 'post0'
       For full logs, run 'nix log /nix/store/5kv2bna6wb2163gyp9kx0qcb8s2wxqhq-python3.9-secp256k1-0.14.0.drv'.

Essentially, the package only expects numbers and dots in the version

@jonringer jonringer merged commit fc7550d into NixOS:master Feb 8, 2022
@jonringer
Copy link
Contributor

uggh, looks like I thought i was on a different tab and merged this...

Guess I'll fix the python package

@L-as
Copy link
Member Author

L-as commented Feb 8, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants