Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_1password: download arm64 binary for aarch64-linux #157306

Merged
merged 1 commit into from
Jan 30, 2022

Conversation

mdtisdall
Copy link
Contributor

@mdtisdall mdtisdall commented Jan 29, 2022

Motivation for this change

aarch64-linux previously downloaded 32-bit binaries, which did not work when creating a 64-bit Linux VM on Apple M1 systems. Updated to now download 64-bit binaries for aarch64-linux systems.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the ofborg-internal-error Ofborg encountered an error label Jan 29, 2022
@SuperSandro2000
Copy link
Member

@ofborg eval

@ofborg ofborg bot requested review from marsam and joelburget January 30, 2022 00:02
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 30, 2022
@SuperSandro2000 SuperSandro2000 merged commit bcd452a into NixOS:master Jan 30, 2022
@cole-h cole-h removed the ofborg-internal-error Ofborg encountered an error label Jan 31, 2022
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants