Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/tests/install: Fix after sandboxed-docs change fc614c3 #156213

Merged
merged 1 commit into from
Jan 29, 2022

Conversation

chkno
Copy link
Member

@chkno chkno commented Jan 22, 2022

Motivation for this change

Fix the install tests after fc614c3 broke them, as noted in #149532 (comment)

Before this change:

$ nix-build nixos/tests/installer.nix -A simple
...
machine: must succeed: nixos-install < /dev/null >&2
...
machine # these 418 derivations will be built:
...
machine # these 359 paths will be fetched (0.00 MiB download, 1272.37 MiB unpacked):
...
machine # building '/nix/store/f450ks5xaq790h43nc5r78x69cr4721q-Make-build-reproducible.patch.drv'...
machine # building '/nix/store/c99ihlhb2lh875spzsl6rnc4058grxvn-autoconf-2.71.tar.xz.drv'...
machine # building '/nix/store/3yar2pnvz7ll79z3jlzx09qnhrsi7zj5-automake-1.16.5.tar.xz.drv'...
machine # warning: error: unable to download 'https://salsa.debian.org/debian/keyutils/raw/4cecffcb8e2a2aa4ef41777ed40e4e4bcfb2e5bf/debian/patches/Make-build-reproducible.patch': Couldn't resolve host name (6); retrying in 303 ms
...
machine # error: unable to download 'https://salsa.debian.org/debian/keyutils/raw/4cecffcb8e2a2aa4ef41777ed40e4e4bcfb2e5bf/debian/patches/Make-build-reproducible.patch': Couldn't resolve host name (6)
machine # warning: error: unable to download 'https://ftpmirror.gnu.org/autoconf/autoconf-2.71.tar.xz': Couldn't resolve host name (6); retrying in 326 ms
...
machine # error: builder for '/nix/store/f450ks5xaq790h43nc5r78x69cr4721q-Make-build-reproducible.patch.drv' failed with exit code 1
machine # error: builder for '/nix/store/c99ihlhb2lh875spzsl6rnc4058grxvn-autoconf-2.71.tar.xz.drv' failed with exit code 1
machine # error: 1 dependencies of derivation '/nix/store/c2hvzjl7x004hjiwf3c10r15s6c1gjs3-autoconf-2.71.drv' failed to build
...
machine # error: 1 dependencies of derivation '/nix/store/vhghw81lw7y0bzdjwfhr2lmyrhnsrps3-source.drv' failed to build
machine # error: 1 dependencies of derivation '/nix/store/vzi1i7flcnrhy8vjp7gqk1b1azk0ky1k-brotli-1.0.9.drv' failed to build
machine # error: 1 dependencies of derivation '/nix/store/710r40n1k5b4867ynrjzlvklzfnyy121-python3-minimal-3.9.9.drv' failed to build
machine # error: 1 dependencies of derivation '/nix/store/6rqfgpxig1vpxv8kmx9fijj8h7c3nh7a-options-docbook.xml.drv' failed to build
machine # error: 1 dependencies of derivation '/nix/store/d47qq562h05ljwid7257hgml41qv1bam-generated-docbook.drv' failed to build
machine # error: 1 dependencies of derivation '/nix/store/rr13dl32wgbhzdzsf9b4a0zfah48qah0-nixos-manual-combined.drv' failed to build
machine # error: 1 dependencies of derivation '/nix/store/ifajc0l06201crpfsz5lilvqk3hxksfw-nixos-manpages.drv' failed to build
machine # error: 1 dependencies of derivation '/nix/store/kk2pbd3dys082cylhfagqr904ljh4bz5-nixos-manual-html.drv' failed to build
machine # error: 1 dependencies of derivation '/nix/store/72il44y04pib9xk1klcrfr6y57ap8as2-system-path.drv' failed to build
machine # error: 1 dependencies of derivation '/nix/store/dvnz5a6rknrim0mw0ys0653pxbw0663m-nixos-system-nixos-22.05pre-git.drv' failed to build
machine: output:
Test "Perform the installation" failed with error: "command `nixos-install < /dev/null >&2` failed (exit code 1)"
cleanup
kill machine (pid 8)

After this change:

$ nix-build nixos/tests/installer.nix -A simple
...
machine: must succeed: nixos-install < /dev/null >&2
...
machine # these 230 derivations will be built:
...
machine # these 359 paths will be fetched (0.00 MiB download, 1208.81 MiB unpacked):
...
machine # Installation finished. No error reported.
machine # installation finished!
(finished: must succeed: nixos-install < /dev/null >&2, in 4291.33 seconds)
...
(finished: waiting for the VM to power off, in 1.93 seconds)
(finished: run the VM test script, in 4715.12 seconds)
test script finished in 4715.12s
cleanup
(finished: cleanup, in 0.00 seconds)
kill vlan (pid 7)
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Jan 22, 2022
@chkno chkno force-pushed the fix-install-tests branch from d986aa1 to 77ae6b6 Compare January 22, 2022 21:27
@chkno chkno requested review from pennae, ajs124 and vcunat January 22, 2022 21:30
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 22, 2022
Copy link
Contributor

@pennae pennae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, those are all things the docs need now.

@chkno chkno force-pushed the fix-install-tests branch from 77ae6b6 to e7a1007 Compare January 23, 2022 08:10
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/703

@pennae pennae merged commit 6b8e882 into NixOS:master Jan 29, 2022
@SuperSandro2000
Copy link
Member

fc614c3

Please use long sha because in the future this reference might return 404/be ambiguous if the repo gets to big.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants