aws-c-common: emit unwind information for RISC-V #155719
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The test suite for
aws-c-common
fails on RISC-V due to libgccbacktrace()
returning 0, which in turn triggers a segfault due to underflow (see awslabs/aws-c-common#873).This is fairly easy to reproduce:
Compile:
Passing
-fasynchronous-unwind-tables
helps. Note gcc_s needs to be explicitly linked to avoid runtimedlopen()
failure:Notes
This appears to be gcc default for AArch64: [AArch64] Turn on -fasynchronous-unwind-tables and -funwind-tables by default.
and on
x86_64
it works out of the box as well, so an alternate approach would be to patch the toolchain instead. If this doesn't turn out to be a widespread issue, just patching up this package works for me.Resolution
Pass -fasynchronous-unwind-tables in CFLAGS for RISC-V.
This fixes functionality which depends on backtrace() and enables
running the test suite without error.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes