setup-hooks: do not pass missing dirs to find

[layus]

find fails when called with an inexistent search path.
That situation may arise when the output is created after by a postFixup hook.

I discovered the bug while building the nss package for #15339.
In that case, the "tools" output is only creted in the postFixup hook by the moveToOutput bin "$tools" here.

More generally, the multiple output features increases the risk to encounter empty or missing prefixes during the build.

The issue was introduced by a refactoring in d71a485.
This PR fixes my comment on that commit. (here)

[mention-bot]

By analyzing the blame information on this pull request, we identified @edolstra to be a potential reviewer

[vcunat]

Alternatively we might opt not to even run fixupOutputHooks on outputs that don't exist at that point, but I think this PR is a better way.

[vcunat]

These returns are bad, as the exit code of the last command is used which means failure. We need return 0.

Stripping (with flags -S) the file /nix/store/y2zcjk85rdfvcrbv06s73k9sn75adiw8-linux-config-4.4.10.
+++ stripAll -S
+++ local stripFlags=-S
+++ local _ls f stripOutput
+++ IFS=
+++ read -r -d '' f
+++ stopNest
+++ nestingLevel=1
+++ echo -en '\033[q'
+++ '[' -d /nix/store/y2zcjk85rdfvcrbv06s73k9sn75adiw8-linux-config-4.4.10 ']'
+++ return
+ exitHandler
+ exitCode=1

[vcunat]

Well, in this particular case the problem is return in #15339 (the first one in stripDirs).

[layus]

Updated this PR to fix the calls to return. Same restrictions as the update in #15339.

[vcunat]

Thanks. Staged with clarifying one more return. (That one seemed correct, but still.)

[layus]

Thanks for following and improving this PR :-)

Le 22 mai 2016 12:18:26 UTC+02:00, "Vladimír Čunát" [email protected] a écrit :

Thanks. Staged with clarifying one more return. (That one seemed
correct, but still.)

---

You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#15405 (comment)

[vcunat]

:-)