optifine: 1.16.5_HD_U_G8 -> 1.18.1_HD_U_H4

[PeterHindes]

Motivation for this change

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.05 Release Notes (or backporting 21.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

This time im targeting main branch.

[collares]

Sorry for being pedantic, but: To help with review, the commit message/PR title should be something like optifine: 1.16.5_HD_U_G8 -> 1.18.1_HD_U_H4, as described in CONTRIBUTING.md. Thanks for your contribution!

[PeterHindes]

My bad its my first comit and I was being lazy thanks for the heads up

[PeterHindes]

is there a way to automate this so that a pr is created every time a new version is released? All we need to is generate the hash and update the file name. Then someone can check it and merge it :)

[collares]

That's a good idea. There is a bot that does this (@r-ryantm) and it's very useful in general, but I would guess it doesn't handle non-free software such as optifine. You can run the script it uses to partly automate the update process, though.

[legendofmiracles]

Another possibility is this: https://github.com/samuela/nixpkgs-upkeep

[bobby285271]

I guess the r-ryantm bot can handle non-free package updates (for example vscode), but you will need to add an updateScript for this package as https://repology.org/project/optifine/versions shows that only nixpkgs has this package so the bot cannot automatically figure out the latest version based on repology. And I think updateScript will also be needed for nixpkgs-upkeep.

[PeterHindes]

isnt vscode opensource though?

[bobby285271]

Visual Studio Code is released under a traditional Microsoft product license.

nixpkgs/pkgs/applications/editors/vscode/vscode.nix

Line 59 in 959104e

license = licenses.unfree;

See #86122 for Code - OSS.

[ryantm]

R-ryantm doesn't care about the license of things it updates.

[bobby285271]

@IvarWithoutBones Would you like to review the update as you are the maintainer of this package?

(Yeah this needs a squash merge)

[IvarWithoutBones]

Other than the commit name this LGTM 👍

Since people still want to play on older versions of the game, and this isn't backwards compatible, we should expose all the major versions in the future. This works for now though.

[PeterHindes]

How do you do multiple versions? I'm new to nixpkgs.

[IvarWithoutBones]

How do you do multiple versions? I'm new to nixpkgs.

You can use a generic builder, much like discord, or yuzu. See their entries in pkgs/top-level/all-packages.nix, they're called differently from other packages.

I think this would deserve it's own optifinePackages set containting all its versions, as to not pollute pkgs. (See lib.attrsets.recurseIntoAttrs from the nixpkgs manual). The existing optifine attribute could just point to the latest version.

That's not a requirement for this to be merged though, just something I'd like to see in the future.