Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zls: unstable-2021-12-11 -> unstable-2021-12-23 #151880

Closed
wants to merge 1 commit into from
Closed

zls: unstable-2021-12-11 -> unstable-2021-12-23 #151880

wants to merge 1 commit into from

Conversation

suhr
Copy link
Contributor

@suhr suhr commented Dec 23, 2021 •
edited
Loading

Motivation for this change

#151518. This PR will be rebased when the zig PR is merged. Done!

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@suhr suhr changed the title Update zls zls: unstable-2021-12-11 -> unstable-2021-12-23 Dec 23, 2021
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Dec 24, 2021
@ofborg ofborg bot requested a review from moni-dz December 24, 2021 09:29
@suhr
Copy link
Contributor Author

suhr commented Jan 1, 2022

And it is rebased.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1 and removed 10.rebuild-darwin: 1-10 labels Jan 1, 2022
@SuperSandro2000 SuperSandro2000 mentioned this pull request Jan 1, 2022
Merged
13 tasks
@allgreed allgreed mentioned this pull request Jan 1, 2022
Closed
@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 10, 2022
@zowoq
Copy link
Contributor

zowoq commented Jul 17, 2022

Sorry, I didn't think to check if there was already an open PR for zls when I did #181193.

@zowoq zowoq closed this Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

@andrewrk andrewrk Awaiting requested review from andrewrk

@moni-dz moni-dz Awaiting requested review from moni-dz

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@suhr @zowoq @moni-dz