-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
phoc: 0.9.0 -> 0.11.0, wlroots_0_12: drop #151519
Conversation
Marking this as draft until #151234 lands in master. We will then add the |
We can finally drop wlroots_0_12! On the other hand, we now need to keep wlroots_0_14 when 0.15 gets merged :P Removing archseer from maintainers per request: NixOS#143785 (comment)
phoc was the last package that depended on this.
4924a71
to
4ea6bfa
Compare
@zhaofengli thanks a lot for this PR and your patience! :) Did you already test this with Phosh (just to be sure)? I just tried to give it a quick go but realized that it's a bit more involved than I thought (plus I never used it before so I could only perform limited testing). Edit: Personal note: I was surprised that I didn't get any notification for https://source.puri.sm/Librem5/phoc/-/merge_requests/241 which I was subscribed to. Turns out the project was archived and moved to https://gitlab.gnome.org/World/Phosh/phoc. So: https://source.puri.sm/Librem5/phoc/-/merge_requests/241 became https://gitlab.gnome.org/World/Phosh/phoc/-/merge_requests/241 which was replaced by https://gitlab.gnome.org/World/Phosh/phoc/-/merge_requests/280 which was superseded by https://gitlab.gnome.org/World/Phosh/phoc/-/merge_requests/300 which finally got merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff LGTM and from my very limited testing of Phoc and Phosh (without a proper Phosh setup) it seems fine.
Yes, to be sure I just re-tested on my PinePhone Pro and it worked without a problem.
Wow, thanks for keeping an eye out for this! I hope their migration to wlroots 0.15.0 won't be as bumpy. |
Awesome, thanks a lot @zhaofengli! And very cool that you use it on your PinePhone Pro :) (And of course that you already have a PinePhone Pro :D) |
Motivation for this change
We can finally drop
wlroots_0_12
! On the other hand, we now need to keepwlroots_0_14
when 0.15 gets merged in #151234 😛 Tested with #151404 on a PinePhone Pro.Closes #118838, and supersedes #143785.
Also removing archseer from the maintainer list per request: #143785 (comment)
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes