-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta.updateWalker: remove because it is not used #151363
Conversation
can someone help me in how to better document this? is running |
Shouldn't this be in the same PR that removes update-walker.sh? (Assuming we actually do want to remove it, I don't know about it.)
No, that's only needed if you change the NixOS docs, not the nixpkgs ones like you have here. |
bf54f0f
to
16bdbfc
Compare
sure i can include the removal into a single PR. I thought more of splitting it up into multiple PRs |
beed247
to
0cb3050
Compare
i just notice, that all additional changes i did are not very helpful for reviewing the PR. Should I remove them? |
0cb3050
to
98c7d66
Compare
i removed all the changes, that were not necessary |
5d9f1cf
to
86233aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
86233aa
to
59c55f4
Compare
is now removed in the last commit |
This seems to have missed a couple of files?
This is still used in one place, I'd suggest moving into the the same directory.
nixpkgs/pkgs/development/lisp-modules/from-quicklisp/barebones-quicklisp-expression.sh Line 54 in 5a17134
Can also remove these from Lines 70 to 72 in 3540d00
|
@Stunkymonkey can you please take a look at the above comment? I currently miss the time to do that. |
Motivation for this change
#103997 removing the documentation about
meta.updateWalker
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes