Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

virtualbox: obey NIX_BUILD_CORES for make invocation, backport to 16.03 #14964

Merged
merged 1 commit into from
Apr 25, 2016
Merged

virtualbox: obey NIX_BUILD_CORES for make invocation, backport to 16.03 #14964

merged 1 commit into from
Apr 25, 2016

Conversation

sheenobu
Copy link
Contributor

@sheenobu sheenobu commented Apr 25, 2016 •
edited
Loading

Things done
  • Tested using sandboxing (nix-build --option build-use-chroot true or nix.useChroot on NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @aszlig, @edolstra and @bbenoist to be potential reviewers

@domenkozar domenkozar merged commit 47f2bf3 into NixOS:release-16.03 Apr 25, 2016
@sheenobu sheenobu deleted the bugfix/14886/vbox_cpucore_1603 branch October 10, 2016 03:37
@Centaurioun Centaurioun mentioned this pull request Mar 1, 2023
Closed
adrianpk added a commit to adrianpk/nixpkgs that referenced this pull request May 31, 2024
@adrianpk
virtualbox: obey NIX_BUILD_CORES for make invocation, backport to 16.…
552d791 
…03 (NixOS#14964)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sheenobu @mention-bot @domenkozar